← Back to gallery

H4-Y — Product Variants Configuration UX rework PROD

2026-05-25 — Gate 2 ship. Closes the H4 arc properly. Narong reviewed H4-X (variant editing at /cafe/settings/attributes) and pushed back: variant configuration should match Odoo's UX (Product form with Attributes & Variants tab + per-variant detail page), not a separate admin. Verified against odoo/odoo 17.0 source. Surfaced new durable feedback rule: default to Odoo UX patterns for every new screen.

Summary

Status: 12/12 prod · 21/21 local · typecheck clean
Commits: nix-outdoor-sales-backend 3f47d67 · nix-cafe 0f37896
Files: 1 migration · 5 modified + 4 new + 2 deleted in nix-cafe (1872 ins / 2241 del = −369 LOC net)
Migration: Applied to prod Supabase: 4 new cols on cafe.product_product + barcode partial-unique idx (verified post-apply)
Source: Notion v0.2 doc, "Product Variants Configuration" section
Tested on: lumiere-coffee.nixtech.app (Starter)

What Narong asked for

"This View may need to join between the tables Product Template (where has_variant = false) & All records from Product Variants."
"Each Product must have Variants shown after Attributes are added" — variants visible on the Product form post-save, not in a separate admin.
"Each Product Variant can be set a price."
"Changing the Product Variant itself is done from Product > (new Tab > Product Variant > Configure)"

Mapped to routes: /cafe/products = joined list · /cafe/products/[id] = Product form with Attributes & Variants tab · /cafe/products/[id]/variants/[variantId] = variant "Configure" page.

What shipped

Routes

REWRITE /cafe/products — joined view: templates-without-variants render as 1 row each (display matches the template); templates-with-variants render N rows labeled by attribute combo (e.g. "Hot, Large"). Click target depends on row shape: single-variant → template edit; multi-variant → variant detail. New listProductsForAdminJoined DAO with explicit LEFT JOINs.
NEW /cafe/products/[id] — Product (template) edit form. General Information section (name, Khmer name, category, hidden toggle; price + image visible on single-variant only). Attributes & Variants section (line editor with attribute dropdown + multi-select value chips; "Save attributes" regenerates variants; variants table lists generated rows with "Configure" link to detail page).
NEW /cafe/products/[id]/variants/[variantId] — Variant detail. Read-only attribute badges + Identifiers (SKU, barcode), Pricing (sales price, cost), Logistics (weight, volume), Image (URL + preview). 7-field form, "Save Changes" patches local state on success.
RETIRED /cafe/settings/attributes — page rewritten to redirect("/products"). attributes-client.tsx (1568 LOC) deleted. starter-products-client.tsx (556 LOC) deleted. Settings nav stripped of Attributes entry.

Schema migration

barcode VARCHAR(64) — tenant-partial-unique index (NULLs multi-coexist).
standard_price_usd DECIMAL(10,2) NOT NULL DEFAULT 0 — Odoo's standard_price (cost).
weight DECIMAL(10,3) + volume DECIMAL(10,3) — nullable.

DAO + action extensions

NEW listProductsForAdminJoined + JoinedProductRow (LEFT JOIN template + variant + category + GROUP-BY combo for variant labels).
NEW getTemplateWithLinesById + getVariantWithContext for the new page server loads.
EXTENDED updateVariant DAO + updateVariantAction for all 7 patchable fields (price, cost, default_code, barcode, weight, volume, image). New 23505 handler for the barcode partial-unique constraint.
EXTENDED createProductAction to return templateId alongside the variant id for post-create navigation to the new product's edit page.

12/12 prod checks ✓

✓	Prod: cafe.product_product has barcode + standard_price_usd + weight + volume
✓	Prod: cafe_product_product_tenant_barcode_unique_idx exists
✓	Login to lumiere-coffee
✓	/cafe/products renders + has joined-list testids
✓	List has product rows (lumiere has 25 product_product seeded)
✓	Click a single-variant product → /cafe/products/[id] loads
✓	Seed throwaway template + variant on prod (TAG-prefixed)
✓	Variant detail page renders full Odoo field set
✓	Edit variant: barcode + cost + weight + volume + save persists (DB round-trip verified)
✓	/cafe/settings/attributes redirects (authenticated)
✓	Settings nav: no Attributes entry on /cafe/settings
✓	No 5xx HTTP responses during the suite

Throwaway template H4YPROBE_* auto-cleaned via process.on("exit") + cascade-delete (template → product_product → combos).

Screenshots

01 · /cafe/products joined view (templates + variants in one list)

02 · /cafe/products/[id] — General Info + Attributes & Variants sections

03 · Variant detail — full Odoo field set (SKU, barcode, prices, weight, volume, image)

04 · Save Changes flash after persisting barcode/cost/weight/volume

05 · /cafe/settings — Attributes entry gone from the nav rail

Regression sweep

51/51 regression green · 12/12 H4-Y prod = 63/63 total. No regressions from this push.

test-phase1-prod.mjs	11/11 (narongix)
test-phase2-sso-outdoor-prod.mjs	6/6 (narongix)
test-phase2-cafe-multishop-prod.mjs	6/6 (demo) · 2 parallel-load flakes on the POS-picker check, solo retry green — matches the known race documented in `project_session_2026_05_24_narong_feedback`
test-m1-prod.mjs	10/10 (narongix)
test-r7-prod.mjs	14/14 (narongix + lumiere)
test-r8-prod.mjs	4/4 (narongix)
test-h4-y-prod.mjs	12/12 (lumiere — this slice)

Open Qs flagged for Narong (defaults applied)

Attribute rename when 0 products use it — with /cafe/settings/attributes retired, an attribute used by zero products has no UI rename/delete path. Default: accept the limitation (small-biz Odoo does the same).
Variants section visibility — Odoo's "Variants" smart button is hidden when product_variant_count ≤ 1. Default: matched in spirit — Attributes & Variants section is always present, variants list populates only when ≥ 1 attribute line + saved + ≥ 1 variant generated.
Per-variant name override — Odoo doesn't expose; computed from template name + attribute values. Default: don't expose.
Per-attribute-value price extras (Odoo's product.template.attribute.value.price_extra) — schema add needed. Default: out of scope for H4-Y.

Notes for Narong

New flow: open Cafe → Products in the sidebar → click any product to edit, or click a multi-variant row's "Configure" link to land directly on a variant. The "+ Product" button creates a template; you add attributes + variants on the next screen.
Variant detail fields: matches Odoo's product.product form — Internal Reference (SKU), Barcode, Sales Price, Cost, Weight, Volume, Image. Attribute values render as read-only badges at the top (they define the variant).
If you bookmarked the old admin: /cafe/settings/attributes now redirects to /cafe/products so old links still work.
Test data on lumiere-coffee: 25 product_product rows from earlier seeding; the joined view renders them mixed (single-variant rows + multi-variant rows where applicable).