R10 — Product Variants (modifiers) PROD

Commits

1606716 (backend) — feat(backend R10): cafe.product_attributes + values + assignments
                    tables + cafe.order_lines.variants jsonb
  migrations/20260510100000_cafe_product_variants.ts
  migrate.js (idempotent registry entry)

144fa81 (cafe) — feat(cafe R10): product variants — Modifiers admin + POS variant
                 picker + lineKey-based cart dedup + variants jsonb on order_lines
                 + Pro Odoo customer_note labels (both Starter+Pro)
  32 files changed, 1963 insertions(+), 72 deletions(-)
  + lib/db/product_attributes.ts, lib/actions/product_attributes.ts
  + lib/pos/attribute-pairs.ts (server-side helper)
  + app/(authed)/settings/modifiers/{page.tsx, modifiers-client.tsx}
  + app/(authed)/pos/_components/{variant-picker.tsx, line-key.ts}
  + integrations into ProductForm, RegisterShell, Cart, CartLineRow,
    pro-handlers, starter-handlers, draft_orders, odoo_sync, queries,
    native-receipt, khmer-receipt, orders POST + Odoo sync route, mounts,
    lockable-shell, starter-lockable-shell, orders-view detail rendering

e509918 (cafe) — fix(cafe R10): translate cafe.products.id → odoo_product_id
                 when building POS productAttributePairs
  Pro+cafe-master uses ShellProduct.id = String(odoo_product_id), but
  cafe.product_attribute_assignments FKs to cafe.products.id (UUID).
  buildShellAttributePairs was keying output by cafe UUID → mounts'
  attributesByProductId.get(p.id) lookup with the int-stringified id
  never matched → picker never opened on prod. Surfaced in the first
  Gate 2 run (10/16 with the picker step timing out). Fix: helper now
  takes a `Map` translation map; Pro+cafe-master
  callers build it from MirrorProduct.cafe_product_id (new field on the
  DAO result). Starter passes identity since ShellProduct.id IS
  cafe.products.id there.
  5 files changed, 53 insertions(+), 20 deletions(-)

R10 prod test (16/16)

Regression sweep

83/83 effective across the R10 ship + the full regression sweep. Sequential execution per the post-R8.2 sid rule (parallel runs sharing the narongix cred would mutually kick).

Architecture notes

Schema:
  cafe.product_attributes         — tenant-scoped templates (name, name_kh, sort_order)
  cafe.product_attribute_values   — options under each attribute, with price_extra_usd
  cafe.product_attribute_assignments — (product_id, attribute_id) PK + is_required + default_value_id
  cafe.order_lines.variants       — JSONB snapshot of chosen values at order time

Cart-line dedup:
  computeLineKey(productId, variants) returns either productId (no variants) or
  `${productId}:${sortedValueIds.join(",")}`. Sort is order-independent so the same
  selection in any array order produces the same key. RegisterShell uses lineKey
  for adjustQty / removeLine / setLineDiscount and as the React key.

Picker UX:
  VariantPicker reads product.attributes (from buildShellAttributePairs server-side).
  Each attribute renders as a row of selectable chips. Required attributes block
  the Add button until chosen. Defaults pre-fill from assignment.default_value_id.
  Cancel discards the click; Add computes unitPriceUsd = base + sum(extras), pushes
  to cart with the lineKey + variants[] snapshot.

Persistence:
  cafe.order_lines.variants jsonb populated on createNativeOrder (orders.ts).
  Drafts (cafe.draft_orders.payload jsonb) carry variants in payload.lines[].variants
  so park/resume preserves the choices.

Pro Odoo sync:
  Worker reads cafe.order_lines.variants, joins valueName labels with ", ",
  passes as CreateOrderLine.variantNote → pos.order.line.customer_note in Odoo.
  Skips real product.attribute modeling (heavy schema + Narong hasn't asked
  for variant-level reporting on the Odoo side yet — defer until requested).

Tier scope:
  Both Starter (uuid product ids) and Pro+cafe-master (Odoo-int shell ids).
  buildShellAttributePairs takes a Map<cafeProductId, shellId> translation
  so the page-level wiring decouples assignment lookup (cafe UUIDs) from the
  ShellProduct id used by tiles + the picker's productAttributePairs map.

Probe output

loading…