← Back to gallery

U6 — Product visibility flip + per-value popover PROD

2026-05-26 Gate 2 ship. Two fixes from Narong's same-day Telegram review. (U6.1) "Hide from POS" → "Show on POS" with new products defaulting to hidden so admins can stage drafts. (U6.2) Per-value popover for editing attribute-value extra prices (Iced +$0.50) — works uniformly across both modifier and SKU-splitting attributes.

Summary

Status: 17/17 prod · 51/51 regression · 68/68 total · awaiting Gate 2 approval
Commits: nix-outdoor-sales-backend 2ec7047 · nix-cafe 7192fa3
Files: 1 new migration · 5 nix-cafe files modified · ~280 LOC net
Migration: One-line ALTER on cafe.product_template.is_hidden — column DEFAULT flips from false to true. Existing rows untouched (preserve current visibility per scoping decision). Applied to prod Supabase via node migrate.js.
Source: Narong's Telegram 2026-05-26 19:21–19:34. Two distinct asks bundled into one Gate cycle.

U6.1 — Visibility flip + default change

Checkbox label flipped to "Show on POS". State semantics inverted at the input (checked={!isHidden}); internal isHidden variable preserved verbatim so DB column name + all downstream POS filters stay unchanged.
New products default to hidden. Verified on prod by creating a brand-new test product via the Admin UI's "New product" modal — DB confirmed is_hidden=true immediately after redirect to /products/[id], and the checkbox rendered unchecked.
Toggle the checkbox + Save → DB flips to is_hidden=false (verified directly via Supabase). Save flash testid hits successfully.
Latent hydration bug fixed: prior code was useState(false) regardless of saved state — now hydrates from template.isHidden via the loader.

U6.2 — Per-value popover for attribute extras

Each value chip on the Attribute Lines editor now has two clickable regions: the chip body toggles selection (existing UX preserved); a small ✎ icon button opens the per-value popover.
Popover fields: Value name, Khmer name (optional), Extra Price USD. Wires to existing updateAttributeValueAction. Schema column cafe.product_attribute_value.price_extra_usd already existed from H4-P1; U6 surfaces it in the UI.
End-to-end prod verification: opened the ✎ popover on a fresh test attribute's "Iced" value → filled $0.50 → saved → popover auto-closed → DB confirmed price_extra_usd = 0.50 → reloaded page → chip rendered with "+$0.50" suffix. Hot value (untouched) stayed without an extra-price node.
Local attributesLibrary state patches on save (no router.refresh round-trip). Outside-click + Escape both dismiss without saving.
Works uniformly for both attribute types (modifier "no SKU split" + SKU-splitting variants). For SKU-split attrs, the per-variant Configure link on the Variants table still wins as the override layer (matches Odoo's two-tier price_extra + lst_price shape).

Files shipped

NEW nix-outdoor-sales-backend/migrations/20260526100000_u6_product_default_hidden.ts
MOD nix-outdoor-sales-backend/migrate.js — idempotent registry entry after U5
MOD nix-cafe/lib/db/schema.ts — isHidden on cafeProductTemplate defaults to true
MOD nix-cafe/lib/db/products.ts — createProduct + rename-create both drop the hardcoded isHidden: false; rely on column default
MOD nix-cafe/lib/db/product_attribute.ts — TemplateRow.isHidden + select/return on both DAOs + createTemplate return shape
MOD nix-cafe/lib/actions/product_attribute.ts — createTemplateAction propagates row.isHidden
MOD nix-cafe/app/(authed)/products/[id]/product-detail-client.tsx — label flip, state hydration fix, chip rendering with extra-price suffix + edit icon, new AttributeValuePopover component (~150 LOC)

17/17 prod checks ✓

✓	Prod: cafe.product_template.is_hidden DEFAULT = true (migration landed)
✓	DAO probe: createTemplate on prod returns isHidden=true
✓	Set up: create test attribute + 2 values via DAO probe
✓	Login to lumiere-coffee
✓	/cafe/products renders + new-product button visible
✓	Open New Product modal + create test product
✓	U6.1: 'Show on POS' label present + checkbox unchecked (default hidden)
✓	U6.1: DB confirms is_hidden=true on the new product
✓	U6.1: tick 'Show on POS' + Save → DB flips is_hidden=false
✓	Attach test attribute line to the new template (DAO probe)
✓	U6.2: reload page + value chips render (Hot, Iced)
✓	U6.2: click ✎ on the Iced chip → popover opens (data-value-id binds correctly)
✓	U6.2: fill +$0.50 + Save → popover auto-closes
✓	U6.2: DB confirms priceExtraUsd = 0.50 on the Iced value
✓	U6.2: chip rendering — Iced shows '+$0.50' suffix after reload; Hot has no extra node
✓	Cleanup: delete test template + attribute via DAO
✓	No 5xx HTTP responses during the suite

Screenshots

01 — /cafe/products on lumiere-coffee with new-product button + category rail

02 — Newly-created product detail with "Show on POS" label visible + checkbox unchecked (default hidden) — proves U6.1 default flip landed

03 — Per-value popover opened on the Iced chip (✎ click) — Value name + Khmer name + Extra price fields ready

04 — Iced chip showing "+$0.50" suffix after popover save + page reload — DB round-trip verified

Regression sweep 51/51

51/51 regression checks green — no regressions from this push.

test-phase1-prod.mjs	11/11
test-phase2-sso-outdoor-prod.mjs	6/6
test-m1-prod.mjs	10/10
test-r7-prod.mjs	14/14
test-r8-prod.mjs	4/4
test-phase2-cafe-multishop-prod.mjs (solo)	6/6

narongix chain ran sequentially (shared get-coffee creds). phase2-cafe-multishop ran solo per feedback_phase2_cafe_multishop_solo_retry — first-attempt green (7th validation of the rule).

Decisions locked (from scope)

Backfill: preserve existing products' current visibility. Only the column default flipped for new inserts. No data migration on existing rows.
U6.2 UI: per-value popover anchored to chip click. Implementation has two clickable regions on each chip — body toggles selection, ✎ icon opens popover (resolved the conflict with the existing toggle behavior).
U6.2 scope: works for both attribute types. Per-variant prices on SKU-split variants still go through the Variants table's Configure link as the override layer.

Scope notes / followups

Global vs per-product extras: the popover edits the global attribute-value row — setting "Iced +$0.50" affects every product using Iced. Matches Odoo's product.attribute.value.price_extra. Per-template overrides (Odoo's deeper product.template.attribute.value.price_extra layer) would need a new join table; out of scope for this slice.
Other latent hydration bugs in product-detail-client.tsx: nameKh and categoryId are still useState("") regardless of saved state, same pattern as the isHidden bug U6 fixed. Touched the file with intent to stay scoped to visibility, so left those as a followup.