T3 — Close-Shift Dialog Polish + Session History Total Sales LOCAL

Summary

Status

21/21 local · awaiting Gate 1 approval

Repos

nix-cafe (no migration)

Files

6 modified (2 close-shift surfaces · 1 cash dialog · 1 sessions DAO · 1 sessions page · 1 sessions client) + 1 regression-test testid update

Approx LOC

~150 LOC net

Sources

Narong's Notion doc 5.22.2026 (Test Run) + screen-recording 2026-05-22 11-20-41.mp4

Scope memo

project_t3_close_shift_dialog_polish_scoping.md

What changed

Close-Shift dialog (both shells — starter-close-shift-dialog.tsx + inline JSX in lockable-shell.tsx):

• T3.1 — Cash in / Cash out rows render unconditionally (even at $0). Previously gated on cashIn > 0 / cashOut > 0.
• T3.2 — Expected row removed from the Cash section. The section-header amount (top-right of the Cash block) IS the expected total. A new Difference row replaces it inside the section, computed live as endingCash − expectedCash.
• T3.3 — Sub-row class shape unified across all sections (space-y-1 text-[12px] pl-4). Cash and non-cash sections render at the same typography weight + indent.
• T3.4 — Each non-cash method section now renders Payments / Counted / Difference $0.00 (parallel structure to Cash, no new input surface — terminal-reported amount IS the counted amount in v1).
• T3.5 — All sections live in ONE container with bg-[#FAFAFA] background and space-y-3 between sections. No inter-section card borders. The Cash count input sits below the container, separated by spacing instead of a forced divider rule. Dropped: Starter's inline "Diff: +$0" below the input + Pro's tinted Difference callout — the in-section Difference row covers both.

Session History (/cafe/pos/sessions):

• T3.6 — New "Total Sales" column. listSessions DAO now exposes totalSales = cashSales + bankTotal per row (both already aggregated by aggregateSessionMetricsBySessionIds; no new query). Threaded through page → client. Desktop table + mobile card both display it.

Cash In / Cash Out dialog (cash-movement-dialog.tsx):

• T3.9 — Replaced T1.3's small inline success banner with a full overlay success state (mirrors close-shift's "Shift closed ✓" pattern): centered checkmark in colored circle + Cash In/Out recorded heading + amount + reason. Auto-dismisses after 1.5s, cash-success testid retained for regression continuity.

Narong's annotated target

From the Notion doc — Narong drew strikethroughs to indicate which rows need indenting and a thick red horizontal line to mark where the single divider belongs (between calculations and Cash count input).

Reference screenshot Narong attached under the "Indent the lines and keep them inside the same container" bullet (16:50).

Out of T3 scope (deferred)

• Cash-with-Difference (no Cash In/Out) — Gate 2 QA probe (T3.7); ❌ = "not yet tested," not a bug.
• Cash-with-Difference + Cash In/Out — Gate 2 QA probe (T3.8).
• Session History filter controls — parked, Narong owes spec.
• Payment-method ↔ Register linking (separate bank accounts per register) — H2.3 banking-flow diagram; parked pending Narong.
• POS Open Orders restructure — T4 (NIX-OS-81's 7 todos), separate slice.

Test results — 21/21 local

Gate 2 plan

• Push nix-cafe karouna-dev, wait ~90s for CF Pages deploy.
• Run test-t3-close-shift-polish-prod.mjs on lumiere-coffee Starter — load the close-shift dialog, assert the new shape end-to-end (sections in one container, Cash in/out rows present at $0, Difference rows in each section). Includes T3.7 / T3.8 QA probes: ring a cash sale + close shift with a Cash count over/short of expected (with and without an intervening Cash In/Out movement).
• Verify Session History "Total Sales" column renders against real session data.
• Verify Cash In/Out success overlay appears + auto-dismisses.
• Run 51-check regression sweep (phase1 + phase2-sso-outdoor + phase2-cafe-multishop + m1 + r7 + r8).
• Update test-r1-10-cash-movements-prod.mjs already adjusted to use close-section-cash-total (Expected testid is gone).