T4 — POS Open Orders Restructure LOCAL

Summary

Status

17/17 local · awaiting Gate 1 approval

Repos

nix-cafe (no migration)

Files

3 modified + 2 new · ~360 LOC net

Source task

NIX-OS-81 "Open Orders"

Scope memo

project_t4_open_orders_restructure_scoping.md

What changed

New files:

• lib/order-number.ts — T4.7 shortenOrderNumber(orderNumber) helper. Strips the shop-code prefix (e.g. BKK1-0003 → 0003) for POS-UI display only; downstream consumers (receipts, exports, Kitchen Display, audit log) keep the full form.
• app/(authed)/pos/_components/discard-tab-modal.tsx — T4.A custom confirm modal replacing the native confirm() dialog. Auto-dismisses on Escape, shows item count + total as a context cue, disabled while the delete is in flight.

Modified — pos-tab-strip.tsx:

• T4.1 — "All orders" tab moved from the right edge (ml-auto) to the leftmost position.
• T4.2 — New "Register" tab between All-orders and the per-order tabs. Lit whenever not in history mode; clicking it returns to the active cart from the All Orders view.
• T4.3 — Empty-cart hint changed from "empty" to "(0)".
• T4.4 — Tabs restyled as discrete chips: bg-[#FAFAFA] + border + rounded-t-md. Active tab brightens to bg-white + green underline.
• T4.7 — Tab labels render the short form via shortenOrderNumber(t.orderNumber).

Modified — pos-workspace.tsx:

• T4.2 — New handleRegister callback; passes onRegister to PosTabStrip.
• T4.5 — New handleResumeOngoing(draftId); threads drafts={stripTabs} + onResumeOngoing to OrdersHistoryView.
• T4.A — Replaced inline confirm("Discard ...") with a DiscardTabModal mount controlled by discardCandidate state. Empty drafts close silently via performClose; ongoing drafts route through the modal.

Modified — orders-history-view.tsx:

• T4.5 — New drafts + onResumeOngoing props. Ongoing drafts (lines > 0) interleave with paid orders in a unified UnifiedRow list. Empty drafts stay in the tab strip only. Status filter pills at the top: Active (default = Ongoing + every non-cancelled order) · Ongoing · Paid · All. Clicking an Ongoing row immediately calls onResumeOngoing; paid rows still load the refund detail in the right pane.
• T4.6 — Punched-up state chips. Color-coded pill: Ongoing (amber) / Paid (green) / Partial (orange) / Refunded (red) / Cancelled (muted). Replaces the prior small <Chip> renders.
• T4.7 — Order labels render the short form in BOTH the list rows and the detail-pane header.

Narong's annotated screenshot

From NIX-OS-81. Red sweeping curve indicates the panel layout shift (Orders panel on the left, with the Register tab as a sibling toggle). The "All orders" button at the top-right is circled to flag the position change.

Defaults applied (confirmed pre-implementation)

• T4.A delete UX: option (b) — tab X shows a confirm modal for ongoing drafts (lines > 0); empty drafts close silently. Native confirm() is gone.
• T4.5 "Active" definition: Ongoing + every non-cancelled paid/refunded order in the shift.
• T4.7 shortening scope: POS UI only (tab labels + orders list rows + detail header). Receipts, Kitchen Display, Daily Sale CSV, Session History, audit log keep the full BKK1-0003 form.
• T4.2 Register-tab shape: single-strip [All orders] [Register] [Order 1] [BKK1-0003] [+ New]. No two-tier nest.

Out of T4 scope

• NIX-OS-83 "Order Details in POS Register Session" — separate slice.
• Session History page-level filter controls (parked, awaiting Narong spec).
• Payment-method ↔ register linking (H2.3 banking flow, parked).

Test results — 17/17 local

Source assertions + helper tsx probe

1. shortenOrderNumber helper exported · ✓
2. shortenOrderNumber tsx probe — 6 cases (BKK1-0003, MULTI-SHOP-0042, 0007, "", null, BKK1-X-0099) · ✓
3. T4.1 — All orders rendered first (left of Register + per-order tabs) · ✓
4. T4.1 — old ml-auto on All orders removed · ✓
5. T4.2 — PosTabStrip exposes onRegister prop · ✓
6. T4.2 — workspace wires handleRegister → setMode('tabs') · ✓
7. T4.3 — empty-cart hint is (0), not 'empty' · ✓
8. T4.4 — tabs have bg-[#FAFAFA] + border (chip look) · ✓
9. T4.5 — OrdersHistoryView accepts drafts + onResumeOngoing · ✓
10. T4.5 — status filter pills (Active/Ongoing/Paid/All), default Active · ✓
11. T4.5 — workspace passes drafts={stripTabs} + onResumeOngoing · ✓
12. T4.6 — color-coded chips via chipConfig helper (5 labels) · ✓
13. T4.7 — tab strip uses shortenOrderNumber for labels · ✓
14. T4.7 — orders-history-view uses shortenOrderNumber in rows + detail header · ✓
15. T4.A — DiscardTabModal exists + workspace mounts it · ✓
16. T4.A — workspace no longer uses native confirm() for tab discard · ✓
17. T4.A — empty drafts close silently; ongoing drafts trigger modal · ✓

Gate 2 plan

• Commit, push nix-cafe karouna-dev, wait for CF Pages deploy.
• test-t4-open-orders-restructure-prod.mjs on lumiere-coffee in-app shell: assert tab order, click Register/All-orders toggle, ring a partial cart (1 item), verify the draft appears in All Orders with "Ongoing" chip, click it to resume, X-close an ongoing tab → discard modal appears + Cancel keeps the cart + Discard removes the tab.
• Verify status filter pills (Ongoing-only shows the draft, Paid-only shows just paid orders).
• Verify order labels render short form on tabs + list + detail header.
• 51-check regression sweep.