U20 — Larger batch (2 wins bundled) — final wavePROD

Summary

Status

6/6 prod · 51/51 regression = 57/57 · shipped

Commit

nix-cafe 6829b4a + nix-outdoor-sales-backend 2cc9f65

Files

8 modified · 1 migration · ~590 LOC net

Migration

CREATE TABLE cafe.product_template_attribute_excl (template_id, value_id, excluded_value_id) with composite PK + cascade FKs

Exclude For — Odoo per-combo exclusion model

• Symmetric write: setLineValueExclusions({templateId, valueId, excludedValueIds}) tx-wraps a REPLACE — drops both directions anchored on valueId (forward + reverse), then re-inserts both directions for each new pair. A single (value_id) lookup at picker / generator time returns the full forbidden partner set without a UNION.
• Configure page UI on /cafe/products/[id]/attributes/[lineId]: <details>/<summary> multi-select grouped by sibling attribute. Auto-saves on draft change via useEffect guarded by ref + draft-equals-saved short-circuit. Summary chips below the picker show AttrName: Value.
• POS variant picker: ShellProductAttributeValue.excludes? populated from attribute-pairs.ts (new SELECT joining the exclusion table). Chips render disabled (line-through + cursor-not-allowed + title="Not available with the current selection.") when forbidden. Auto-deselect useEffect sweeps prior selections that become forbidden when the user picks a sibling.
• Variant generator: regenerateVariantsForTemplate filters Cartesian combos before INSERT (drops any combo containing an excluded pair). Zero-allowed safeguard preserves the H4-X invariant: if exclusions wipe every combo, fall back to a single default variant.

Mixed-mode templates warning

• Amber banner on /cafe/products/[id] inside the Attributes & Variants section, above the line editor.
• Detection: build a Set<"instant" | "never"> from draft.map(ln => attributesLibrary.find(a => a.id === ln.attributeId)?.createVariant). Banner appears when the set contains BOTH modes.
• Copy explains the architectural fall-through: variant generator only multiplies on Instant attributes; Never values act as modifiers on every generated SKU; admins who want separate SKUs per Never value need to create a new attribute in Instant mode.
• testid product-mixed-mode-warning. Informational, not blocking — admins can save mixed-mode templates.

6/6 prod checks ✓

Screenshots (click to enlarge)

Mid-Gate-2 finds

• Cold-Worker noise on first Gate 2 (3/6) — wrangler deployments list showed the deploy at 00:22 UTC, but the warm Worker on lumiere may have been mid-restart when the test fired <20s later. Solo retry without code changes: 6/6 clean. Doesn't quite match the existing feedback_phase2_cafe_multishop_solo_retry (that's specifically about POS-master suite racing the narongix chain) — this is a different shape (immediately after a fresh deploy). Not worth a new memo for one occurrence.
• Probe template-literal stitching — Gate 1 round 1: the generator probe referenced vRed.id / vLarge.id in ${...} interpolations expecting OUTER JS scope, but those variables are defined INSIDE the probe body. Fix: compute the forbidden check inside the probe + report a boolean.
• inArray not in generator probe imports — added.
• mkdir-before-redirect 8th burn — applied the pre-mkdir fix.

Architectural notes

• Symmetric write keeps the read code dead simple: a single (value_id) → excluded_value_id[] lookup returns the full forbidden partner set. Cost: 2 rows per save instead of 1; reads: 1 query instead of 1 UNION. Net win for the read-heavy POS path.
• REPLACE semantics on save (not upsert) matches the Configure page's multi-select source-of-truth. Removing E from V's list also removes V from E's list — admins don't have to manually clean up the other side.
• Auto-deselect on picker is load-bearing: without it, the picker could land in a state where Add is enabled on a forbidden combo. Specifically: user picks A → picks B (allowed) → picks new value C on attribute_X → C excludes B → without auto-deselect, B stays selected and Add lights up.
• Zero-allowed safeguard in generator preserves the H4-X "every template has ≥1 product_product" invariant. If an admin builds a 100% conflicting exclusion grid (by accident), they still get a usable template with 1 default variant + no SKU-multiplication. Better than 0 variants + a template that can't be added to POS.

Regression sweep — 51/51 ✓